-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish v0.1.4
to NPM
#260
Conversation
* fix: remove unnecessary prop `style` causing console warning Hardcode `editors` prop to `101` to keep the current behavior. See: https://blog.codepen.io/documentation/prefill/#:~:text=editors%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%3A%20%22101%22%2C%20//%20Set%20which%20editors%20are%20open.%20In%20this%20example%20HTML%20open%2C%20CSS%20closed%2C%20JS%20open Fixes #178
* chore: remove `use(...)` from all components * chore: remove all imports of `use` from all components
* chore: set the Modal's events prop default to be an empty object * fix: set event props default value through a factory function Source: https://eslint.vuejs.org/rules/require-valid-default-prop
* chore: remove `bluebird` from the docs * chore: remove `bluebird` from package.json
Fixes #23 - Adds import statement to include the missing input component
* chore: added missing `mobileNative` prop to colorpicker This should fix #34 * chore: add missing button to colorpicker * chore: update Colorpicker's unit tests and snapshot * chore: set `mobileNative` default to false
Fixes the issue that `use(Buefy)` in the root index file was meaningless or rather harmful to Vue 3 apps. It caused a "not a function" error in some environment: see #221 (comment) Simply removes `use(Buefy)` in the root index file.
* chore: migrate MenuItem's `model` option to Vue3's `modelValue` Fixes: #19 - Migrates MenuItem's `model` option to `modelValue`. - Updates the model value event. - Updates what the MenuItem emits for the model value change (Source: https://v3-migration.vuejs.org/breaking-changes/v-model.html) * chore: replaced active prop with modelValue * fix: update unit test for MenuItem * chore: update the `Menu` and `Sidebar` examples
✅ Deploy Preview for buefy-nextdocs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
I rewrite the CHANGELOG according to my preference, however we should discuss and establish a minimum guideline for the CHANGELOG. Categorizes the issue #19 as a "Breaking changes". Removes "Fix" prefixes in the "Fixes" section because they look redundant. Writes the issues instead of the solutions in the headlines. Moves the issue #178 to a new category "Fixes (docs)" because it does not matter to the core buefy-next library. Adds the following fixes: - #23 - #257 - #171 (docs)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kikuomax this PR is ready for review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! I will push dev
to main
with the following commands:
git checkout main
git merge --ff-only dev
git push
Thank you!!! |
Proposed Changes
v0.1.4
to NPMDepends on #259 to be complete before this PR is pulled into main.