Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ICMP checksum check and set risk if mismatch detected. #1464

Merged
merged 1 commit into from
Mar 2, 2022

Conversation

utoni
Copy link
Collaborator

@utoni utoni commented Mar 1, 2022

Signed-off-by: Toni Uhlig matzeton@googlemail.com

src/lib/ndpi_main.c Outdated Show resolved Hide resolved
@IvanNardi
Copy link
Collaborator

Curiosity: is that feature somehow related to #719?

@utoni
Copy link
Collaborator Author

utoni commented Mar 1, 2022

Curiosity: is that feature somehow related to #719?

It is indeed. But it does not fix the SSH in ICMP tunnel detection in a "stable" way so I've decided against any reference to #719. :)

src/lib/ndpi_utils.c Outdated Show resolved Hide resolved
src/lib/ndpi_main.c Outdated Show resolved Hide resolved
Signed-off-by: Toni Uhlig <matzeton@googlemail.com>
@utoni utoni force-pushed the add/icmp-tunnel-chksm-risk branch from 7914ca3 to d7657dd Compare March 2, 2022 11:09
@sonarcloud
Copy link

sonarcloud bot commented Mar 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@utoni utoni merged commit e8559a4 into ntop:dev Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants