-
Notifications
You must be signed in to change notification settings - Fork 892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Implement CI on Windows. #1483
Conversation
@lnslbrty now It compiles for both libgcrypt and internal one.
Note also that ndpiSimpleIntegration compilation step is disabled as it fails too, rrd stuff too. |
@IvanNardi @lnslbrty what do you think is the best option? |
|
.github/workflows/build.yml
Outdated
@@ -195,7 +221,15 @@ jobs: | |||
- name: Configure nDPI on MacOS | |||
if: startsWith(matrix.os, 'macOS') && startsWith(matrix.arch, 'x86_64') && startsWith(matrix.compiler, 'default-cc') | |||
run: | | |||
env CC=clang CFLAGS='-Werror' ./autogen.sh --enable-option-checking=fatal --enable-debug-messages ${{ matrix.gcrypt }} ${{ matrix.msan }} ${{ matrix.pcre }} ${{ matrix.maxminddb }} --enable-tls-sigs | |||
env CC=clang CFLAGS='-Werror' ./autogen.sh --enable-option-checking=fatal --enable-debug-messages ${{ matrix.gcrypt }} ${{ matrix.msan }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this change on MacOS?
Just to be sure I fully understand the current situation: ndpi compiles on Windows (with lots of warnings) but the executable "doesn't work": does that mean that some unit tests fail or that it always crashes? |
Kudos, SonarCloud Quality Gate passed! |
@lnslbrty We can merge it as it is. There is warnings but build is passing. @IvanNardi build pass, but tests do not run (diff).
|
Thanks for the clarification. Could you share a link with the logs, please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can merge this PR in the current state and we can fix the issues step-by-step later. Exactly like we did for the big-endian stuff
Now that all issues on big endian were solved by talented people and that we finally saw this green light near s390 line, we can move to new issues and a new red line.
This PR is marked as WIP as I need several attempts to make it work but it will add build and test process on Windows server.
I already did that within nfstream project and saw several issues related to new lightweight encryption library an so on.