Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced ndpiReader's libjson-c support with libnDPI's internal serialization interface. #1535

Merged
merged 1 commit into from
May 7, 2022

Conversation

utoni
Copy link
Collaborator

@utoni utoni commented Apr 29, 2022

  • Fixes ndpiReader and JSON output `-k' #1528
  • Serialization Interface should also fuzzed
  • libjson-c may only be used in the unit test to verify the internal serialization interface
  • Serialization Interface supports tlv(broken), csv and json
  • Unit test does work again and requires libjson-c

Signed-off-by: lns matzeton@googlemail.com

@utoni utoni marked this pull request as draft April 29, 2022 17:13
@utoni utoni force-pushed the fix/ndpi-reader-serialization branch 2 times, most recently from 8857764 to 380815b Compare April 29, 2022 20:41
Copy link
Collaborator

@IvanNardi IvanNardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not using serialization code, but LGTM

@utoni
Copy link
Collaborator Author

utoni commented Apr 30, 2022

The PR is not ready yet. But will be soon. Thanks for the approval anyway. ;)

@utoni utoni force-pushed the fix/ndpi-reader-serialization branch 3 times, most recently from 10b6e99 to 2964710 Compare May 1, 2022 11:49
@lgtm-com
Copy link

lgtm-com bot commented May 1, 2022

This pull request introduces 2 alerts when merging 2964710 into 02d0b5f - view on LGTM.com

new alerts:

  • 2 for Empty branch of conditional

@utoni utoni force-pushed the fix/ndpi-reader-serialization branch 2 times, most recently from ac6ff03 to 5da360f Compare May 1, 2022 19:11
@utoni
Copy link
Collaborator Author

utoni commented May 1, 2022

Ready for review. A follow-up task: Merge ndpiReader's CSV output (-C) with the serialization interface provided by libnDPI.

@utoni utoni marked this pull request as ready for review May 1, 2022 19:13
…lization interface.

 * Fixes ntop#1528
 * Serialization Interface should also fuzzed
 * libjson-c may only be used in the unit test to verify the internal serialization interface
 * Serialization Interface supports tlv(broken), csv and json
 * Unit test does work again and requires libjson-c

Signed-off-by: lns <matzeton@googlemail.com>
@utoni utoni force-pushed the fix/ndpi-reader-serialization branch from 5da360f to d1b346e Compare May 1, 2022 19:30
@sonarcloud
Copy link

sonarcloud bot commented May 1, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@utoni
Copy link
Collaborator Author

utoni commented May 6, 2022

Ready to merge @IvanNardi ?

@IvanNardi IvanNardi merged commit 87f93ea into ntop:dev May 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ndpiReader and JSON output `-k'
2 participants