Commits on May 5, 2023

1. Remove special handling of some TCP flows without SYN …

   This piece of code has multiple problems:
   * nDPI is able to detect some TCP protocols even with mid-flows (i.e.
   without the initial packets of the session); TLS is the most
   significative example
   * since e6b332a it is perfectly valid
   to not pass the TCP Handshake packets to nDPI
   * in any case, we shouldn't call `ndpi_detection_giveup()`. That
   function is usually called by the application and we end up calling it
   twice in some cases.
   
   The simple solution is to completely remove that code: process these
   kinds of flows like everyone else.
   
   Note that the application can always avoid to pass to nDPI any TCP flows
   without the initial handshake; the flow managemnt is always up to the
   application.
   
   Looking at the CI results, some rare flows are now processed significantly
   longer. As a follow-up we could look into that.

   

   IvanNardi committed May 5, 2023
   Configuration menu

   • View commit details
   • Copy full SHA for 8727ea0
   • Browse repository at this point

   Copy the full SHA

   8727ea0 View commit details

   Browse the repository at this point in the history