Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Service Location Protocol dissector. #2036

Merged
merged 1 commit into from
Aug 1, 2023
Merged

Add Service Location Protocol dissector. #2036

merged 1 commit into from
Aug 1, 2023

Conversation

utoni
Copy link
Collaborator

@utoni utoni commented Jul 7, 2023

No description provided.

@utoni utoni force-pushed the add/service-location-protocol-dissector branch 3 times, most recently from bbcb958 to 1fa2458 Compare July 7, 2023 08:13
@utoni
Copy link
Collaborator Author

utoni commented Jul 7, 2023

I would like to implement version 1 together with the dissection of multiple <URL Entry>s.
But without any pcap, this might not be a good idea.

@utoni
Copy link
Collaborator Author

utoni commented Jul 7, 2023

Besides the missing documentation, what do you think @IvanNardi ?

@IvanNardi
Copy link
Collaborator

I would like to implement version 1 together with the dissection of multiple <URL Entry>s. But without any pcap, this might not be a good idea.

I don't know if in this trace there is one or multiple url: srv_v1_anon.zip

@utoni
Copy link
Collaborator Author

utoni commented Jul 7, 2023

I would like to implement version 1 together with the dissection of multiple <URL Entry>s. But without any pcap, this might not be a good idea.

I don't know if in this trace there is one or multiple url: srv_v1_anon.zip

It does not contain multiple URL entries, but at least version 1. That'll help for now. Thanks! :)

IvanNardi
IvanNardi reviewed Jul 7, 2023
View reviewed changes
Copy link
Collaborator

@IvanNardi IvanNardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing update in doc/protocols.rst

src/lib/ndpi_main.c Outdated Show resolved Hide resolved
src/lib/ndpi_main.c Outdated Show resolved Hide resolved
src/lib/ndpi_main.c Outdated Show resolved Hide resolved
@utoni utoni force-pushed the add/service-location-protocol-dissector branch 3 times, most recently from 396e503 to 5332479 Compare July 7, 2023 14:21
@utoni
Copy link
Collaborator Author

utoni commented Jul 11, 2023

It will take some more time as I need to forge a PCAP that contains multiple URL entries.

@utoni utoni force-pushed the add/service-location-protocol-dissector branch from 5332479 to 7450062 Compare July 22, 2023 11:39
IvanNardi
IvanNardi reviewed Jul 22, 2023
View reviewed changes
src/lib/protocols/slp.c Outdated Show resolved Hide resolved
@utoni utoni force-pushed the add/service-location-protocol-dissector branch from 7450062 to d5de32d Compare July 31, 2023 07:45
@utoni
Copy link
Collaborator Author

utoni commented Jul 31, 2023 •
edited
Loading

Ready for merge soon.

ToDo:

  • v1 dissection
  • URL entry dissection should obey num_auth for offset calculation

@utoni utoni force-pushed the add/service-location-protocol-dissector branch 2 times, most recently from 89bb8c0 to 095b79e Compare July 31, 2023 22:15
@utoni
Add Service Location Protocol dissector.
c52d9d3 
Signed-off-by: Toni Uhlig <matzeton@googlemail.com>
@utoni utoni force-pushed the add/service-location-protocol-dissector branch from 095b79e to c52d9d3 Compare July 31, 2023 22:46
@utoni utoni requested a review from IvanNardi July 31, 2023 22:46
@sonarcloud
Copy link

sonarcloud bot commented Jul 31, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@utoni utoni merged commit e4d3d61 into ntop:dev Aug 1, 2023
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IvanNardi IvanNardi IvanNardi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@utoni @IvanNardi