Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve CORBA detection #2167

Merged
merged 4 commits into from
Nov 27, 2023
Merged

Improve CORBA detection #2167

merged 4 commits into from
Nov 27, 2023

Conversation

0xA50C1A1
Copy link
Contributor

Please sign (check) the below before submitting the Pull Request:

Describe changes:

Added additional checks for Zipped Inter-ORB Protocol (ZIOP) and Unreliable Multicast Inter-ORB Protocol (MIOP, CORBA over UDP).

Copy link
Collaborator

@IvanNardi IvanNardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there isn't any specific reasons, could you restore the corba.pcap test, please?
If you are able, could you try to merge these 3 files corba.pcap, miop.pcap and ziop.pcap into only one trace, called corba.pcap?

Copy link

sonarcloud bot commented Nov 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@0xA50C1A1
Copy link
Contributor Author

If there isn't any specific reasons, could you restore the corba.pcap test, please? If you are able, could you try to merge these 3 files corba.pcap, miop.pcap and ziop.pcap into only one trace, called corba.pcap?

No problem, I did it.

@IvanNardi
Copy link
Collaborator

If there isn't any specific reasons, could you restore the corba.pcap test, please? If you are able, could you try to merge these 3 files corba.pcap, miop.pcap and ziop.pcap into only one trace, called corba.pcap?

No problem, I did it.

If I am not mistaken, there isn't the flow with the "ZIOP" pattern in the file... Might be useful to add it, if possible?

@0xA50C1A1
Copy link
Contributor Author

If there isn't any specific reasons, could you restore the corba.pcap test, please? If you are able, could you try to merge these 3 files corba.pcap, miop.pcap and ziop.pcap into only one trace, called corba.pcap?

No problem, I did it.

If I am not mistaken, there isn't the flow with the "ZIOP" pattern in the file... Might be useful to add it, if possible?

Here it is. But this may not be the best sample of ZIOP traffic, since here this packet is the last one in the flow.
Снимок экрана от 2023-11-27 14-30-00

@IvanNardi
Copy link
Collaborator

If there isn't any specific reasons, could you restore the corba.pcap test, please? If you are able, could you try to merge these 3 files corba.pcap, miop.pcap and ziop.pcap into only one trace, called corba.pcap?

No problem, I did it.

If I am not mistaken, there isn't the flow with the "ZIOP" pattern in the file... Might be useful to add it, if possible?

Here it is. But this may not be the best sample of ZIOP traffic, since here this packet is the last one in the flow. Снимок экрана от 2023-11-27 14-30-00

Ok, that'll do fine for the time being

@0xA50C1A1
Copy link
Contributor Author

If there isn't any specific reasons, could you restore the corba.pcap test, please? If you are able, could you try to merge these 3 files corba.pcap, miop.pcap and ziop.pcap into only one trace, called corba.pcap?

No problem, I did it.

If I am not mistaken, there isn't the flow with the "ZIOP" pattern in the file... Might be useful to add it, if possible?

Here it is. But this may not be the best sample of ZIOP traffic, since here this packet is the last one in the flow. Снимок экрана от 2023-11-27 14-30-00

Ok, that'll do fine for the time being

If there isn't any specific reasons, could you restore the corba.pcap test, please? If you are able, could you try to merge these 3 files corba.pcap, miop.pcap and ziop.pcap into only one trace, called corba.pcap?

No problem, I did it.

If I am not mistaken, there isn't the flow with the "ZIOP" pattern in the file... Might be useful to add it, if possible?

Here it is. But this may not be the best sample of ZIOP traffic, since here this packet is the last one in the flow. Снимок экрана от 2023-11-27 14-30-00

Ok, that'll do fine for the time being

I guess this could be useful for detecting mid-flows.

@IvanNardi IvanNardi merged commit 0b6e261 into ntop:dev Nov 27, 2023
33 checks passed
@IvanNardi
Copy link
Collaborator

Thanks!

@0xA50C1A1 0xA50C1A1 deleted the improve/corba branch November 27, 2023 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants