Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some fast CRC16 algorithms implementation #2195

Merged
merged 5 commits into from
Dec 5, 2023
Merged

Add some fast CRC16 algorithms implementation #2195

merged 5 commits into from
Dec 5, 2023

Conversation

0xA50C1A1
Copy link
Contributor

@0xA50C1A1 0xA50C1A1 commented Dec 4, 2023

Please sign (check) the below before submitting the Pull Request:

Link to the related issue: #2194

Describe changes:

Implementation of some commonly used CRC16 algorithms. Should make it easier to implement dissectors of protocols such as IEEE C37.118, Ether-S-Bus and Genisys.

@0xA50C1A1
Copy link
Contributor Author

@IvanNardi @utoni could you take a look, please?

@0xA50C1A1 0xA50C1A1 marked this pull request as draft December 4, 2023 21:57
@0xA50C1A1 0xA50C1A1 marked this pull request as ready for review December 5, 2023 01:20
src/lib/third_party/include/ndpi_crc.h Outdated Show resolved Hide resolved
src/lib/third_party/src/ndpi_crc.c Outdated Show resolved Hide resolved
src/lib/third_party/src/ndpi_crc.c Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Dec 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@IvanNardi
Copy link
Collaborator

@0xA50C1A1, can I merge it or are you doing to push other stuff?

@0xA50C1A1
Copy link
Contributor Author

@0xA50C1A1, can I merge it or are you doing to push other stuff?

Yea, sure.

@IvanNardi IvanNardi merged commit 72601a6 into ntop:dev Dec 5, 2023
33 checks passed
@IvanNardi
Copy link
Collaborator

Thanks for all your contributions!

@0xA50C1A1 0xA50C1A1 deleted the new-feature/crc16-ccit branch December 5, 2023 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants