Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PIA (Private Internet Access) support #2250

Merged
merged 3 commits into from
Jan 9, 2024
Merged

Add PIA (Private Internet Access) support #2250

merged 3 commits into from
Jan 9, 2024

Conversation

0xA50C1A1
Copy link
Contributor

Please sign (check) the below before submitting the Pull Request:

Describe changes:

PIA is a quite popular VPN service.

IvanNardi
IvanNardi requested changes Jan 9, 2024
View reviewed changes
Copy link
Collaborator

@IvanNardi IvanNardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor issue

src/lib/ndpi_main.c Outdated Show resolved Hide resolved
@0xA50C1A1
Copy link
Contributor Author

Just a minor issue

Ok, I've fixed it.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 9, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@IvanNardi
Copy link
Collaborator

Just a minor issue

Ok, I've fixed it.

Thank you

@IvanNardi IvanNardi merged commit 3d57dec into ntop:dev Jan 9, 2024
33 checks passed
@0xA50C1A1 0xA50C1A1 deleted the new-app/private-internet-access branch January 9, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IvanNardi IvanNardi IvanNardi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0xA50C1A1 @IvanNardi