Fix datatype of redshift #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The convert_to_multimessenger_parameters used to return the redshift values as astropy Quantity objects. This caused issues later, when the sample arrays were copied that contained these redshift values, turning every sample parameter to astropy Quantity objects, which becomes problematic when finally writing the posterior samples to file. Additionally a small bug fix induced by my previous update on how to load the EOS.
mcoughlin
merged commit 628db61
into
nuclear-multimessenger-astronomy:main
0 of 4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The convert_to_multimessenger_parameters function used to return the redshift values as astropy Quantity objects. This caused issues later, when the sample arrays were copied that contained these redshift values, turning every sample parameter to astropy Quantity objects, which becomes problematic when finally writing the posterior samples to file.
Additionally a small bug fix induced by my previous update on how to load the EOS.