Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor unit tests to support local pytest runs #319

Merged

Conversation

bfhealy
Copy link
Collaborator

@bfhealy bfhealy commented Feb 9, 2024

This PR refactors the analysis and models unit tests to support local pytest runs. The changes are as follows:

  • The analysis test now gets svdmodels from the nmma/tests/data directory
  • Bu2019nsbh models are added to the test data directory (instead of Bu2019lm to stay below Github's maximum file size threshold)
  • The models tests are split by zenodo and gitlab in case one site is temporarily down
  • Model caching is removed from the CI workflow
  • Docs are updated to mention local pytest runs

@bfhealy bfhealy linked an issue Feb 9, 2024 that may be closed by this pull request
@bfhealy bfhealy changed the title WIP: Refactor unit tests to support local pytest runs Refactor unit tests to support local pytest runs Feb 9, 2024
@bfhealy bfhealy marked this pull request as ready for review February 9, 2024 22:01
@sahiljhawar
Copy link
Member

LGTM

@mcoughlin mcoughlin merged commit a2ac497 into nuclear-multimessenger-astronomy:main Feb 13, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change model caching to support local pytest runs
3 participants