Adding functionality for using Bayestar fit input for inclination #330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems that the ultrasat filters it breaking the pytest |
mcoughlin
approved these changes
Mar 8, 2024
nmma/em/analysis.py
Outdated
| @@ -377,6 +377,16 @@ def get_parser(**kwargs): | |||
| default=False, | |||
| ) | |||
|
|
|||
| parser.add_argument( | |||
| "--fit-file", | |||
nmma/em/prior.py
Outdated
| @@ -58,6 +59,92 @@ def get_instantiation_dict(self): | |||
| return instantiation_dict | |||
|
|
|||
|
|
|||
| def inclination_prior_from_fit(priors, args): | |||
nmma/em/prior.py
Outdated
| @@ -119,4 +206,7 @@ def convert_mtot_mni(parameters): | |||
| priors_dict["inclination_EM"] = ConditionalGaussianIotaGivenThetaCore(**setup) | |||
| priors = bilby.gw.prior.ConditionalPriorDict(priors_dict) | |||
|
|
|||
| if args.fit_file: | |||
|
@tsunhopang I think you have to update the tests as well |
tsunhopang
merged commit 47d4461
into
nuclear-multimessenger-astronomy:main
3 of 4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR allows for the Bayestar output fits to be used as inclination prior for NMMA;
A small test case is showing an expected behaviour
Corner plot without the fit input
Corner plot with the fit input
The fit input;
Currently, only a fixed distance prior is supported and, by default, takes the maP sky location. Subsequent PRs will expand the functionality.