Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint: format js #365

Merged
merged 6 commits into from
Sep 24, 2024
Merged

lint: format js #365

merged 6 commits into from
Sep 24, 2024

Conversation

nobkd
Copy link
Collaborator

@nobkd nobkd commented Sep 16, 2024

Most changes are formatting or whitespace.

Imports are now categorized in 3 categories and ordered by alphabet respectively:

  • node:* internals
  • package imports
  • internal imports / imports from the current package

After imports and top level variable definitions, there are two newlines separating them from the actual code.
Exactly one newline at the end of the js file.

packages/glow/src/glow.js Outdated Show resolved Hide resolved
@tipiirai
Copy link
Contributor

I'm good with the changes, except for the whitespace prior function name — which I'd like to discuss more

@nobkd
Copy link
Collaborator Author

nobkd commented Sep 24, 2024

This part was automatically formatted, but I also don't like the space there, so I changed it.

@nobkd nobkd changed the title chore: format js lint: format js Sep 24, 2024
@tipiirai tipiirai merged commit 8dc2aa9 into nuejs:master Sep 24, 2024
4 checks passed
@nobkd nobkd deleted the chore/format-js branch September 24, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants