- added AzurePipelinesPool as a abstraction for vmImage and on prem p… #1398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matkoch
force-pushed
the
develop
branch
2 times, most recently
from
e652c9a
to
6ed9e4d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to use nuke.build with our on-prem agents. Unfortunately, I didn't find a solution to pass a pool name to be considered in the final yml file.
I saw that other people also had a similar problem: #1173, #749.
My proposition is to create an additional abstraction, AzurePipelinesPool, which can be either a Microsoft-hosted agent (vmImage) or a self-hosted agent, as that is essentially what a pool is in Azure Pipelines.
Here is a proposal for the changes, and I am open to suggestions.
I also removed
imagesparameters fromAzurePipelinesAttributebecause if you really need to run your targets on multiple vmImages, it's probably better to configure multipleAzurePipelinesAttribute, am I right?I confirm that the pull-request: