Fix reference graph generator's "halt" generator to inherit customizations #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
didn't inherit the original object generator's specs or providers. This can cause crashes when reference graph generator is used with object generators which have custom specs and/or semantics providers.
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #51 +/- ##
==========================================
+ Coverage 90.51% 90.62% +0.10%
==========================================
Files 35 35
Lines 3480 3509 +29
==========================================
+ Hits 3150 3180 +30
+ Misses 330 329 -1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #50 .
This fix adds a method to ObjectGenerator named
derive_generator(), which enables callers to create one object generator based on another. It presently allows you to override the config settings in the "derived" object generator, but not the spec registry or semantics providers (which get carried over unchanged). ReferenceGraphGenerator uses this method to create its "halt" generator. This is sufficient to fix the issue.Also added a unit test which triggered the bug originally, and now passes.