Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

-safe-string compatibility #54

Merged
merged 10 commits into from
Nov 6, 2017
Merged

Conversation

rgrinberg
Copy link
Contributor

Fixes lambda-term for 4.06.0

@rgrinberg
Copy link
Contributor Author

This works but unfortunately break compatibility with the old Camomile (0.8.5) which means that this release won't work on 4.02.3.

This is fixable in 2 ways:

  • We can remove the problematic asserts that don't work with the new Camomile
  • Backport Camomile to work with 4.02.3

I will look for a solution in a separate PR.

@rgrinberg rgrinberg merged commit 9d24c18 into ocaml-community:master Nov 6, 2017
@rgrinberg rgrinberg deleted the safe-string branch November 6, 2017 09:50
@rgrinberg
Copy link
Contributor Author

I've restored 4.02.3 compatibility in Camomile. So lambda term will require Camomile 0.8.7 on 4.02.3

@Leonidas-from-XIV
Copy link
Member

Leonidas-from-XIV commented Nov 30, 2017

I tried building it on 4.05 but it is broken:

File "src/lTerm_unix.ml", line 342, characters 32-51:
Error: This expression has type bytes but an expression was expected of type
         string
      ocamlc src/lTerm.{cmo,cmt} (exit 2)

and

File "src/lTerm.ml", line 334, characters 32-51:
Error: This expression has type bytes but an expression was expected of type
         string

Removing safe-string from the src/jbuild fixes it for me, but obviously this is not the proper solution.

Oh, turns out it builds with camomile 0.8.7... @rgrinberg wouldn't it be best to just set 0.8.7 as minimum dependency version here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants