Switch to dune #64
Merged
Switch to dune #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could we split this in two so we can commit the travis config first? It would be nice to try running the travis stuff over the dune update before we put it in. |
|
Sure. #65 is there to add just the travis config |
Signed-off-by: Anurag Soni <anuragsoni.13@gmail.com>
ghost
approved these changes
Aug 23, 2018
|
Patch looks good. Travis testing is not yet enabled for this repository BTW, I checked but I don't have enough permissions to enable it |
|
I've turned travis on, good catch. (From now on, if I forget, open an issue.) So we should be able to kick this again if we want. |
|
I re-opened the pull request to trigger a travis build! |
|
The travis build seems to have succeeded. Merging this, thanks! |
ghost
merged commit 
ghost
mentioned this pull request
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Anurag Soni anuragsoni.13@gmail.com