Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Camomile with uu* #46

Merged
merged 2 commits into from
Jun 20, 2022
Merged

Replace Camomile with uu* #46

merged 2 commits into from
Jun 20, 2022

Conversation

tmattio
Copy link
Collaborator

@tmattio tmattio commented Jun 20, 2022

This is #43 with a clean history and co-authors attributions.

nojb and others added 2 commits June 20, 2022 18:48
Co-authored-by: ZAN DoYe <zandoye@gmail.com>
Co-authored-by: Thibaut Mattio <thibaut.mattio@gmail.com>
Co-authored-by: Nicolás Ojeda Bär <n.oje.bar@gmail.com>
Co-authored-by: Jeremie Dimino <jeremie@dimino.org>
@tmattio tmattio changed the title Replace Camomile with uucd/uutf Replace Camomile with uu* Jun 20, 2022
@tmattio
Copy link
Collaborator Author

tmattio commented Jun 20, 2022

I've tested the changes with lambda-term and utop and everything seems to be working.
Merging now and I'll make a release shortly. Thanks a lot for all the work @nojb and @kandu!

@tmattio tmattio merged commit bb78fec into ocaml-community:master Jun 20, 2022
@tmattio tmattio mentioned this pull request Jun 20, 2022
tmattio added a commit to tmattio/opam-repository that referenced this pull request Jun 20, 2022
CHANGES:

* Replace Camomile with uu* (Nicolás Ojeda Bär, ZAN DoYe, Thibaut Mattio, ocaml-community/zed#46)
@@ -3,4 +3,4 @@
(public_name zed)
(wrapped false)
(flags (:standard -safe-string))
(libraries bytes react camomile result charInfo_width))
(libraries bytes react result uutf uucp uuseg))

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uucp not mentioned in dune-project

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @olafhering, I've pushed a fix in f2495e2

tmattio added a commit to tmattio/opam-repository that referenced this pull request Jun 20, 2022
CHANGES:

* Replace Camomile with uu* (Nicolás Ojeda Bär, ZAN DoYe, Thibaut Mattio, ocaml-community/zed#46)
@nojb
Copy link
Contributor

nojb commented Jun 20, 2022

I've tested the changes with lambda-term and utop and everything seems to be working. Merging now and I'll make a release shortly. Thanks a lot for all the work @nojb and @kandu!

I had forgotten about this, thanks for pushing it over the finish line. Cheers!

tmattio added a commit to tmattio/opam-repository that referenced this pull request Jun 30, 2022
CHANGES:

* Replace Camomile with uu* (Nicolás Ojeda Bär, ZAN DoYe, Thibaut Mattio, ocaml-community/zed#46)
emillon added a commit to emillon/utop that referenced this pull request Jul 4, 2022
This updates utop to use the uu packages instead of camomile, following
ocaml-community/zed#46 and ocaml-community/lambda-term#109.
emillon added a commit to emillon/utop that referenced this pull request Jul 5, 2022
This updates utop to use the uu packages instead of camomile, following
ocaml-community/zed#46 and ocaml-community/lambda-term#109.
kit-ty-kate pushed a commit to ocaml-community/utop that referenced this pull request Jul 5, 2022
This updates utop to use the uu packages instead of camomile, following
ocaml-community/zed#46 and ocaml-community/lambda-term#109.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants