Acr value support

[Glowsome]

All Submissions:

• Have you followed the plugin Contributing guideline?
• Does your code follow the WordPress' coding standards?
• Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Changes proposed in this Pull Request:

Fixes #331
This PR enhances the plugin with capabillities on handling acr_values - in which the request to the IDP includes a specific authentication contract as defined on the IDP.
Next to that enhancements have been made to also check - when set that the - if defined authentication contract is honored.

How to test the changes in this Pull Request:

1. Define the added acr_values field option with a contract that exists on the IDP ie. urn:domain:contract:my_method_of_auth ( this is the exact name of the authentication uri as defined on a/the IDP.
2. Test login, and see that the added (acr_-)values to the url will influence the behaviour of the authentication contract with the IDP.
3. Verify manual url-manipulation check so it will error / disallow login ( remove the added acs_values from url manually and try it on your IDP)

Other information:

• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your changes, as applicable?
• Have you successfully run tests with your changes locally?

Changelog entry

Enter a summary of all changes on this Pull Request. This will appear in the changelog if accepted.

• Added acr_values support & verification checks that it when defined in options is honored.

[Glowsome]

@timnolte would it be possible to trigger the code standard workflow also via workflow_dispatch: ?
If i understand the workings this is stopping me to run the review prior to opening/adding a PR

• Glowsome

[timnolte]

@Glowsome actually I think GitHub changed how GitHub Actions work. I know that one of the big issues recently was the fact that someone could change the GitHub Actions in a PR and could compromise the integrity of the code. Right now I have to approve all of the GitHub Actions to run. However, as I mentioned in the previous PR I have setup the project so that you can run all of these checks locally, and actually if you have your local development environment setup correctly it should be not allowing you to even commit your changes locally because there are checks in place. When you setup the project locally are you running npm run setup? If you run that the entire project should be setup the right way for local development. I obviously don't have any way to enforce that people do this but I've done a ton of work to make sure people have all of the tools they need to contribute. I'll try taking a look at what has changed with the GitHub Actions permissions, which I'm pretty sure would still prevent you from running a workflow on-demand as well.

[Glowsome]

@timnolte you are thinking too high of me, i just fiddle around in code, and when needed use github desktop (on a windows box)
so in interacting with you i am sort-of self-studying in a crash-course manner to get everything in order so it can be incorporated in the upcoming release.
To me all the workflows/unittests etc is all like a complete new world for me ... (i'm just an old guy, so i got stuck somewhere in the past regarding this)

• Glowsome

[timnolte]

Ah, sure thing. No worries we'll work through it. Thanks for all your patience!

[Glowsome]

@timnolte i also thank you for your patience with me ... i seem to be claiming alot of your time here.
Maybe somewhere in the future there is time for something like a session to guide me more then just having a convo over a/the PR :)
... can you re-trigger the code-standard workflow ?

• Glowsome

[Glowsome]

@timnolte awesomesauce .... seems all checks have now completed without issues so i'd guess you should be good for incorporating it into a/the new release ?

[timnolte]

@Glowsome I made a couple of notes. I'll take care of the tweaks after I merge. Thanks for all the work!

[timnolte]

@Glowsome just a heads up if you are interested to check the adjustments I made to your code you can check them out in this PR: #389

I did actually find a mistake that I missed in the initial code review so it was a good thing that I took time to refactor some of this code. Thanks for your contribution!

[Glowsome]

@Glowsome just a heads up if you are interested to check the adjustments I made to your code you can check them out in this PR: #389

I did actually find a mistake that I missed in the initial code review so it was a good thing that I took time to refactor some of this code. Thanks for your contribution!

I have taken a quick look at it, and i like it - and i enjoyed working with you in getting this enhancement into play, as to me it really is a value-add to the plugin in regards of functionality.
But on the other side it makes me feel old having to consume so much time from you to get myself up to par and my aged skills.

• Glowsome