Refine okta_group_memberships and improve documentation #1120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
desired amount of time to perform its read in the API. This is useful in testing and could benefit situations where guards on eventual group consistency are needed.
MikeMondragon-okta
force-pushed
the
fix_1094_okta_group_memberships
branch
from
695476c
to
e2db56a
Compare
`okta_group_memberships` resource. Closes #1094
MikeMondragon-okta
force-pushed
the
fix_1094_okta_group_memberships
branch
from
e2db56a
to
a0ff118
Compare
monde
commented
May 19, 2022
| @@ -140,21 +151,33 @@ func checkIfGroupHasUsers(ctx context.Context, client *okta.Client, groupId stri | |||
| groupUsers = append(groupUsers, additionalUsers...) | |||
| } | |||
|
|
|||
| // Create set of users | |||
| // We need to return false if there isn't any users present. For eventual | |||
There was a problem hiding this comment.
@exitcode0 I think checkIfGroupHasUsers needs to exit early if no users are found here. See my notes in the commit about eventual consistency and the backoff used in create versus no backoff in read.
bretterer
approved these changes
May 23, 2022
|
Released as v3.28.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
okta_groupallowing for a delay before the it does its API readcheckIfGroupHasUsersin theokta_group_membershipsresourceokta_group_membershipsresourceokta_group_membershipsresource