Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix resource pagination in resource okta_resource_set #1196

Merged
merged 1 commit into from
Jul 8, 2022
Merged

Fix resource pagination in resource okta_resource_set #1196

merged 1 commit into from
Jul 8, 2022

Conversation

monde
Copy link
Collaborator

@monde monde commented Jul 8, 2022

Fix resource pagination in resource okta_resource_set as the /api/v1/iam/resource-sets/%s/resources endpoint is not returning pagination links at this time.

OKTA_ALLOW_LONG_RUNNING_ACC_TEST=true TF_ACC=1 \
go test -tags unit -mod=readonly -test.v -run ^TestAccResrouceOktaResourceSet_Issue1097_Pagination$ ./okta 2>&1
=== RUN   TestAccResrouceOktaResourceSet_Issue1097_Pagination
--- PASS: TestAccResrouceOktaResourceSet_Issue1097_Pagination (114.91s)
PASS
ok      github.com/okta/terraform-provider-okta/okta    115.542s

@monde
Fix resource pagination in resource okta_resource_set as the
186faaf 
`/api/v1/iam/resource-sets/%s/resources` endpoint is not return
pagination links at this time. Closes #1097
@monde monde merged commit 111c432 into master Jul 8, 2022
@monde monde deleted the issue_1097_okta_resource_set_pagination branch July 8, 2022 22:09
@monde
Copy link
Collaborator Author

monde commented Jul 8, 2022

Released in https://github.com/okta/terraform-provider-okta/releases/tag/v3.31.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vijetmahabaleshwar-okta vijetmahabaleshwar-okta vijetmahabaleshwar-okta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@monde @vijetmahabaleshwar-okta