fix leeway refresh token #1596
Merged
fix leeway refresh token #1596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tien Nguyen <duytien.nguyen@okta.com>
monde
approved these changes
Jun 13, 2023
okta/resource_okta_app_oauth_test.go
Outdated
| @@ -87,7 +87,7 @@ func TestAccResourceOktaAppOauth_refreshToken(t *testing.T) { | |||
| // Skipping for now assuming that the okta account doesn't have this feature enabled. | |||
| // If this feature is enabled or Okta releases this to all this test should be enabled. | |||
| // SEE https://help.okta.com/en/prod/Content/Topics/Apps/apps-fbm-enable.htm | |||
| t.Skip("This is an 'Early Access Feature' and needs to be enabled by Okta, skipping this test as it fails when this feature is not available") | |||
| // t.Skip("This is an 'Early Access Feature' and needs to be enabled by Okta, skipping this test as it fails when this feature is not available") | |||
There was a problem hiding this comment.
nit: delete instead of commenting out code
Signed-off-by: Tien Nguyen <duytien.nguyen@okta.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the error refresh_token_leeway does not accept 0 or empty value from tf file