Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve okta_email_customization resource #1616

Merged
merged 2 commits into from
Jun 29, 2023

Conversation

monde
Copy link
Collaborator

@monde monde commented Jun 29, 2023

  • Correct delete in okta_email_customization resource
  • Improve it's documentation
  • Deprecate force_is_default and no-op its behavior
  • Note in documentation to use depends_on meta argument to manage primary is_default and secondary dependent customizations.

/cc @BalaGanaparthi

go clean -testcache && TF_ACC=1 go test -tags unit -mod=readonly -test.v -run ^TestAccResourceOktaEmailCustomization_crud$ ./okta 2>&1
2023/06/29 11:39:20 [INFO]  running with default http client
=== RUN   TestAccResourceOktaEmailCustomization_crud
2023/06/29 11:39:34 [INFO]  running with default http client
2023/06/29 11:39:34 [INFO]  running with experimental max_api_capacity configuration at 80%
2023/06/29 11:39:34 [INFO]  running with default http client
2023/06/29 11:39:34 [INFO]  running with experimental max_api_capacity configuration at 80%
--- PASS: TestAccResourceOktaEmailCustomization_crud (14.20s)
PASS
ok      github.com/okta/terraform-provider-okta/okta    14.963s

documentation. Deprecate `force_is_default` and no-op its behavior. Note
in documentation to use `depends_on` meta argument to manage primary
`is_default` and secondary dependent customizations.

/cc @BalaGanaparthi
@MikeMondragon-okta MikeMondragon-okta merged commit 3ca4832 into master Jun 29, 2023
1 check passed
@monde monde deleted the refine_okta_email_customization branch June 29, 2023 19:07
@monde monde mentioned this pull request Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants