Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure logo updated when source file changes #514

Merged
merged 3 commits into from
Jun 28, 2021
Merged

Ensure logo updated when source file changes #514

merged 3 commits into from
Jun 28, 2021

Conversation

gavinbunney
Copy link
Contributor

Compute and store the hash of the logo alongside the path to ensure any changes to the source file are reflected on Okta. Without this change, the logo is not updated as the path attribute hasn't changed.

Fixes: #512

Validated:

  1. New logo set
  2. Change logo path
  3. Change logo image

Example output

  ~ resource "okta_app_bookmark" "confluence" {
        id                  = "XXXXXXXXXXX"
      ~ logo                = "./../../assets/app-confluence.png (320385e0df8be4557e73dfdb2e58ca53da25ecdf8a9b85f0be4d7f61e9281681)" -> "./../../assets/app-confluence.png (6904d1f02905f4365311ec9d9e161eda995001dc122150f466922ef41f9022da)"
        name                = "bookmark"
        # (10 unchanged attributes hidden)
    }

@bogdanprodan-okta bogdanprodan-okta merged commit e856505 into okta:master Jun 28, 2021
@gavinbunney gavinbunney deleted the logo-hash branch June 28, 2021 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

App logo change doesn't force new logo to be uploaded
2 participants