Added okta_user_admin_roles resources #518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Description: "ID of a Okta User", | ||
| ForceNew: true, | ||
| }, | ||
| "admin_roles": { |
There was a problem hiding this comment.
Could you please add a validator here?
"admin_roles": {
Type: schema.TypeSet,
Optional: true,
Description: "User Okta admin roles - ie. ['APP_ADMIN', 'USER_ADMIN']",
Elem: &schema.Schema{
Type: schema.TypeString,
ValidateDiagFunc: elemInSlice(validAdminRoles),
},
},
|
You could also go ahead and deprecate admin_roles in |
@bogdanprodan-okta Great idea. Deprecated & added note to the docs |
bogdanprodan-okta
approved these changes
Jul 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow for user admin roles to be managed outside the user schema.
Needed to allow directory based users to not have to have an explicit user schema created, and rather just manage the
admin_rolesin Terraform.Validation
Tested via acceptance tests