Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Include 404 check for okta_app_user resource at App level #695

Merged
merged 1 commit into from
Oct 8, 2021

Conversation

ymylei
Copy link
Contributor

@ymylei ymylei commented Oct 7, 2021

If the top level application is deleted, all the downstream assignments go with it.

This patch includes a 404 check when the app resource is being verified in the Read stage and marks the resources as gone if it cannot find the app.

@ymylei
Copy link
Contributor Author

ymylei commented Oct 7, 2021

Test results:

➜  terraform-provider-okta git:(app_users_404_patch) TEST_FILTER="TestAccOktaAppUser" make testacc
go mod tidy
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v  -run TestAccOktaAppUser -timeout 120m
?       github.com/okta/terraform-provider-okta [no test files]
=== RUN   TestAccOktaAppUser_crud
--- PASS: TestAccOktaAppUser_crud (43.34s)
=== RUN   TestAccOktaAppUser_retain
--- PASS: TestAccOktaAppUser_retain (21.06s)
PASS
ok      github.com/okta/terraform-provider-okta/okta    64.624s
testing: warning: no tests to run
PASS
ok      github.com/okta/terraform-provider-okta/okta/internal/apimutex  0.073s [no tests to run]
testing: warning: no tests to run
PASS
ok      github.com/okta/terraform-provider-okta/okta/internal/transport 0.109s [no tests to run]
?       github.com/okta/terraform-provider-okta/sdk     [no test files]

@bogdanprodan-okta bogdanprodan-okta merged commit 9271546 into okta:master Oct 8, 2021
@ymylei ymylei deleted the app_users_404_patch branch October 8, 2021 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants