DICOM: fix raw RGB tile reading #3997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Conflicting PR. Removed from build BIOFORMATS-push#458. See the console output for more details.
|
|
This is now included and passing tests: https://merge-ci.openmicroscopy.org/jenkins/job/BIOFORMATS-push/1617/console, https://merge-ci.openmicroscopy.org/jenkins/job/BIOFORMATS-test-repo/1502/. |
dgault
approved these changes
Jun 8, 2023
There was a problem hiding this comment.
The logic for the change seems to make sense. Builds and tests have continued to pass with this included and manual testing with public samples from https://downloads.openmicroscopy.org/images/DICOM/ does not show any noticeable regressions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an incorrect tile offset calculation issue when working with uncompressed brightfield WSI data. I don't currently have permission to share the original test dataset, but will try to make an artificial dataset that demonstrates the issue once tests are confirmed to pass.
Without this PR,
showinf -noflat -resolution 3on the affected dataset showed scrambled tiles. With this PR,showinf -noflat -resolution 3should matchshowinf -format MinimalTiffon the corresponding file for resolution 3.I would not expect this to change behavior for anything other than the uncompressed brightfield WSI case, so tests should continue to pass.
/cc @dclunie.