Add deprecation flags for LuraWave/LuraWaveCode/LuraWaveService/LuraWaveServiceImpl #4032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aveServiceImpl This codec depends on a third-party proprietary library with a license code. This commit marks these classes as deprecated in preparation for their removal in the upcoming major release of Bio-Formats
melissalinkert
approved these changes
Jun 29, 2023
There was a problem hiding this comment.
As discussed separately, it's probably worth deprecating the underlying codec/service implementations in ome-codecs, but otherwise 👍. For removal, keep in mind there is an lwf-stubs dependency (https://github.com/ome/ome-stubs/tree/master/lwf-stubs) that will need to be removed; that's easy to miss if doing git grep -i lurawave or similar.
dgault
approved these changes
Jul 4, 2023
This was referenced Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This codec depends on a third-party proprietary library with a license code. This commit marks these classes as deprecated in preparation for their removal in the upcoming major release of Bio-Formats
The removal of these classes will minimally affect the following locations:
build.xmlcomponents/bio-formats-plugins/src/loci/plugins/config/FlexWidgets.javacomponents/bio-formats-plugins/src/loci/plugins/config/libraries.txtcomponents/bio-formats-plugins/src/loci/plugins/in/ImagePlusReader.javacomponents/bio-formats-plugins/src/loci/plugins/in/ImportProcess.javacomponents/formats-api/src/loci/formats/readers.txtcomponents/formats-bsd/matlab/bfGetReader.mcomponents/formats-bsd/matlab/bfopen.mcomponents/formats-bsd/src/loci/formats/tiff/TiffCompression.javacomponents/formats-bsd/test/loci/formats/utests/CompressDecompressTest.javacomponents/formats-gpl/src/loci/formats/in/FlexReader.javalwf-stubsdependency (see Add deprecation flags for LuraWave/LuraWaveCode/LuraWaveService/LuraWaveServiceImpl #4032 (review))