Adjust tests following new website deployment #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The LocationTest of ome-common-java were using some hardcoded URLs which seem to have been hanging following the deployment of the new website. This PR updates the tests for URL locations to use the root of the new website in HTTP and HTTPS mode as well as non-existing subdirectory.
|
No objections to using www.openmicroscopy.org, and good to know about this dependency, thanks. |
|
Looks fine to me. |
|
Thanks @rleigh-codelibre and @kennethgillen. Merging to restore Travis and unlock the work on #12 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed while investigating the timeouts in #12
The LocationTest of ome-common-java is using some hardcoded URLs and the tests seem
to be hanging following the deployment of the new website. This PR updates these tests to use the root of the new website in HTTP and HTTPS as well as a non-existing URL.
The concern with these tests has always been the dependency on an external resource albeit one we are maintaining actively /cc @kennethgillen While mocking would be a better unit test, an alternative here would be to use https://github.com/ome/ome-common-java instead.