Add initial API for downsampling images #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loci.common.image.IImageScaler is the interface, which only contains one method. loci.common.image.SimpleImageScaler is the initial implementation backported with minor modifications from private PRs.
|
|
|
As discussed today, having this in an |
|
LGTM so that the interface and the simple implementation can be consumed by the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
loci.common.image.IImageScaleris the interface, which only contains one method.loci.common.image.SimpleImageScaleris the initial implementation backported with minor modifications from private PRs.There is also a new unit test class (
SimpleImageScalerTest), which should be passing.Discussed in Formats meeting on 10 October; see also https://trello.com/c/spl6WleR/74-ome-tiff-pyramid-testing-phase-ii. This is a prerequisite for being able to do something like
bfconvert -pyramid.