Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ZarrService #49

Closed
wants to merge 1 commit into from
Closed

Add ZarrService #49

wants to merge 1 commit into from

Conversation

dgault
Copy link
Member

@dgault dgault commented May 5, 2020

Required for testing of ongoing Zarr reader and writer work

@sbesson
Copy link
Member

sbesson commented May 5, 2020

From Travis CI

+./minio version
‘version’ is not a minio sub-command. See ‘minio --help’.
The command "cd location-server && ./start-location.sh && cd .." failed and exited with 1 during .

This probably brings us back to the discussion in #47 (comment)

@sbesson
Copy link
Member

sbesson commented May 5, 2020

Once the Travis CI issue is fixed, should we release this immediately as a patch or minor release increment? This might be required to allow ome/bioformats#3554 to pass Travis and be included in the daily CI build /cc @joshmoore @jburel

@dgault
Copy link
Member Author

dgault commented May 5, 2020

I dont know about releasing it since this is very much a prototype for testing purposes only. I can hardcode the BF PR to just use the ZarrServiceImpl directly if that is easier for getting it into the daily merge build

@sbesson
Copy link
Member

sbesson commented May 5, 2020

Understood. 👍 for hard coding the service implementation in the Bio-Formats PR to get this easily deployed and tested for now.

@dgault dgault closed this May 5, 2020
@sbesson sbesson mentioned this pull request May 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants