Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: Fix the build failure on Power 10 #2153

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

build: Fix the build failure on Power 10 #2153

wants to merge 1 commit into from
+3 −2

Conversation

varad-ahirwadkar
Copy link

Description

This PR resolves the build failure on Power 10 by using qualified names cpu::q10n::out_round and cpu::q10n::saturate

Fixes Build failure on Power10.

Checklist

General

  • Do all unit and benchdnn tests (make test and make test_benchdnn_*) pass locally for each commit? - Ran
100% tests passed, 0 tests failed out of 200
Total Test time (real) = 1439.56 sec
  • Have you formatted the code using clang-format?

Bug fixes

  • Have you included information on how to reproduce the issue (either in a github issue or in this PR)?

@varad-ahirwadkar varad-ahirwadkar requested a review from a team as a code owner October 7, 2024 05:05
mgouicem
mgouicem approved these changes Oct 7, 2024
View reviewed changes
Copy link
Contributor

@mgouicem mgouicem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@varad-ahirwadkar
build: Fix the build failure on Power 10
face26a 
Signed-off-by: Varad Ahirwadkar <varad.ahirwadkar1@ibm.com>
@github-actions github-actions bot added the platform:cpu-ppc64 PowerPC label Oct 8, 2024
@varad-ahirwadkar
Copy link
Author

Hi @densamoilov, could you please review this PR? Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgouicem mgouicem mgouicem approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
platform:cpu-ppc64 PowerPC
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build failure on Power10
2 participants
@varad-ahirwadkar @mgouicem