Allow optional description to be lazily evaluated function #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansd
added a commit
to ansd/gomega
that referenced
this pull request
Nov 16, 2019
ghost
reviewed
Nov 18, 2019
|
This looks like a great addition! Very handy. |
Co-authored-by: David Ansari <dansari@pivotal.io>
|
Looks great to me too. Thanks @ansd! |
blgm
pushed a commit
that referenced
this pull request
Nov 18, 2019
|
It seems the lazily evaluated function lost. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested in #193 and #351, allow a single argument of type
func() stringto be passed as an optional description. This function gets lazily evaluated if there's a failure and the returned string is used to annotate the failure message.