Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Degradation process of BasicVSR #487

Closed
mrluin opened this issue Aug 15, 2021 · 7 comments
Closed

Degradation process of BasicVSR #487

mrluin opened this issue Aug 15, 2021 · 7 comments
Assignees
Labels
kind/enhancement refactoring, improving CI, template, etc.

Comments

@mrluin
Copy link

mrluin commented Aug 15, 2021

Hi,

Thanks for your great work!

I only know about the value kernel size and sigma, but I am not familar with Matlab. Could you provide python code of degradation process of BasicVSR, or provide some references? Thanks again.

@ckkelvinchan ckkelvinchan self-assigned this Aug 15, 2021
@ckkelvinchan
Copy link
Member

For BIx4, we use MATLAB to resize the images: lq = imresize(gt, 0.25).

For BDx4, you can find the MATLAB script here.

@mrluin mrluin closed this as completed Aug 15, 2021
@innerlee innerlee added the kind/enhancement refactoring, improving CI, template, etc. label Aug 18, 2021
@innerlee
Copy link
Contributor

@ckkelvinchan do you know a way to approximate the matlab resize?

@innerlee
Copy link
Contributor

Getting rid of the matlab dependency would be a great thing

@ckkelvinchan
Copy link
Member

I think I have seen the python code somewhere before, I can look for it.

@jasoromir
Copy link

Here, since you helped a lot with your repository. I thought I could lend a hand too.
https://github.com/Ding-Liu/NLRN_v0/blob/master/imresize.py

@ckkelvinchan
Copy link
Member

Here, since you helped a lot with your repository. I thought I could lend a hand too.
https://github.com/Ding-Liu/NLRN_v0/blob/master/imresize.py

Thank you! I will have a look at that.

@ckkelvinchan
Copy link
Member

Added in #507. Note that the implementation is not exactly the same as the MATLAB implementation, though the difference is small.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement refactoring, improving CI, template, etc.
Projects
None yet
Development

No branches or pull requests

4 participants