-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Add MATLAB-like bicubic interpolation #507
Conversation
One important thing is to be explicit about whether the implementation is the "same" as matlab's. From my point of view, this is a |
Also please rebase master to pass CI |
And give licence info if the code is adapted from elsewhere |
Codecov Report
@@ Coverage Diff @@
## master #507 +/- ##
==========================================
+ Coverage 80.50% 80.60% +0.10%
==========================================
Files 190 191 +1
Lines 10344 10457 +113
Branches 1533 1553 +20
==========================================
+ Hits 8327 8429 +102
- Misses 1789 1794 +5
- Partials 228 234 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
* Add matlab_bicubic.py * Change function to class, add unittest * update, pull from master * Add license
Motivation
Existing image and video SR methods commonly use the
imresize
function in MATLAB to generate LR images. It means that one would need MATLAB to generate such LR images.Modification
This PR adds the Python version of the MATLAB
imresize
function.Note:
There is a slight difference between the official MATLAB implementation and this implementation. For instance, when using BasicVSR on REDS4, we achieve the following results: