Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat]: Add Instance-aware Image Colorization #1173

Closed
wants to merge 24 commits into from

Conversation

ruoningYu
Copy link
Contributor

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Please briefly describe what modification is made in this PR.

Whose help do you want? @ them here!

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with some of those projects.
  • CLA has been signed and all committers have signed the CLA in this PR.


@DATASETS.register_module()
class CocoDataset:
"""Dataset for COCO."""
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this class inherit from BasicConditionalDataset?

@zengyh1900 zengyh1900 added this to the 1.0.0rc2 milestone Oct 8, 2022
@zengyh1900 zengyh1900 assigned zengyh1900 and unassigned Z-Fran Oct 10, 2022
@zengyh1900 zengyh1900 added status/WIP work in progress normally priority/P0 highest priority kind/feature request new feature/model/datasets/config etc. and removed Planned feature labels Oct 11, 2022
@zengyh1900 zengyh1900 linked an issue Oct 11, 2022 that may be closed by this pull request
2 tasks
@zengyh1900
Copy link
Collaborator

Will fix in #1370

@zengyh1900 zengyh1900 closed this Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature request new feature/model/datasets/config etc. priority/P0 highest priority status/WIP work in progress normally
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New Models] Instance-aware colorization
4 participants