Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] fix ssim only calculate on the first channel bug #1515

Merged
merged 2 commits into from
Dec 19, 2022

Conversation

Z-Fran
Copy link
Collaborator

@Z-Fran Z-Fran commented Dec 9, 2022

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

def img_transform(img,
                  crop_border=0,
                  input_order='HWC',
                  convert_to=None,
                  channel_order='rgb'):
    ....

    if crop_border != 0:
        img = img[crop_border:-crop_border, crop_border:-crop_border, None]

    return img

If crop_border is not 0, the image is wrongly expanded at the second dimension.
All SSIM evaluation with convert_to=None and crop_border!=0 setting will trigger this bug.

Modification

fix img_transform function

Who can help? @ them here!

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with some of those projects.
  • CLA has been signed and all committers have signed the CLA in this PR.

@Z-Fran Z-Fran added this to the Backlog milestone Dec 9, 2022
@Z-Fran Z-Fran self-assigned this Dec 9, 2022
@Z-Fran Z-Fran linked an issue Dec 9, 2022 that may be closed by this pull request
3 tasks
@Z-Fran Z-Fran requested review from LeoXing1996 and removed request for zengyh1900 December 19, 2022 04:39
@codecov
Copy link

codecov bot commented Dec 19, 2022

Codecov Report

Base: 88.03% // Head: 88.03% // No change to project coverage 👍

Coverage data is based on head (2f1fbbb) compared to base (4ee8e91).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff            @@
##           dev-1.x    #1515   +/-   ##
========================================
  Coverage    88.03%   88.03%           
========================================
  Files          383      383           
  Lines        24176    24176           
  Branches      3793     3793           
========================================
  Hits         21283    21283           
  Misses        2077     2077           
  Partials       816      816           
Flag Coverage Δ
unittests 88.03% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmedit/evaluation/metrics/metrics_utils.py 90.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Z-Fran Z-Fran merged commit b0f5592 into open-mmlab:dev-1.x Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] SSIM only calculate on the first channel for three-channels images.
3 participants