Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] update inference demo markdown #1921

Merged

Conversation

JayceNing
Copy link
Contributor

@JayceNing JayceNing commented Jul 3, 2023

#1919

Motivation

This is a task received from the contributor communication group. I'm glad to contribute to the openmmlab open source community.

Modification

Update the markdown file https://github.com/open-mmlab/mmagic/blob/main/docs/en/user_guides/inference.md

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with some of those projects.
  • CLA has been signed and all committers have signed the CLA in this PR.

@CLAassistant
Copy link

CLAassistant commented Jul 3, 2023

CLA assistant check
All committers have signed the CLA.

@zengyh1900 zengyh1900 linked an issue Jul 5, 2023 that may be closed by this pull request
@zengyh1900 zengyh1900 self-requested a review July 5, 2023 06:02
@zengyh1900 zengyh1900 marked this pull request as draft July 5, 2023 06:13
@zengyh1900 zengyh1900 marked this pull request as ready for review July 5, 2023 06:13
Copy link
Collaborator

@zengyh1900 zengyh1900 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@zengyh1900 zengyh1900 merged commit 1c932c0 into open-mmlab:main Jul 5, 2023
3 checks passed
@OpenMMLab-Assistant-004

Hi @BUPT-NingXinyu,

We'd like to express our appreciation for your valuable contributions to the mmagic. Your efforts have significantly aided in enhancing the project's quality.
It is our pleasure to invite you to join our community thorugh Discord_Special Interest Group (SIG) channel. This is a great place to share your experiences, discuss ideas, and connect with other like-minded people. To become a part of the SIG channel, send a message to the moderator, OpenMMLab, briefly introduce yourself and mention your open-source contributions in the #introductions channel. Our team will gladly facilitate your entry. We eagerly await your presence. Please follow this link to join us: ​https://discord.gg/UjgXkPWNqA.

If you're on WeChat, we'd also love for you to join our community there. Just add our assistant using the WeChat ID: openmmlabwx. When sending the friend request, remember to include the remark "mmsig + Github ID".

Thanks again for your awesome contribution, and we're excited to have you as part of our community!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Docs] Modifications for MMagic inference demo documentation
4 participants