Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CodeCamp2023-552] Complete Chinese and English documents advanced_guides/structures.md #1982

Merged
merged 8 commits into from
Aug 21, 2023

Conversation

MING-ZCH
Copy link
Contributor

[CodeCamp2023-552] Complete Chinese and English documents advanced_guides/structures.md

Motivation

Task#552: Complete Chinese and English documents advanced_guides/structures.md

Modification

Complete Chinese and English documents advanced_guides/structures.md

BC-breaking (Optional)

No

Use cases (Optional)

No

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.

  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.

  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.

  • New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.

  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with some of those projects, like MMDet or MMCls.

  • CLA has been signed and all committers have signed the CLA in this PR.

Copy link
Collaborator

@LeoXing1996 LeoXing1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @MING-ZCH , thanks for your contribution. Please install pre-commit hook via pip install pre-commit before creating commit in order to fix lint error automatically.

Since you have already create a commit and PR, you can use the following commands to roll back:

git reset --soft HEAD^   # reset commit and remain changes
pip install pre-commit   # install pre-commit hook package
pre-commit install  # install pre-commit hook for current repo
git commit -m "xxxxx"  # create commit
git push -f <repository> <refspec>  # -f for force push

Or, you can run the following commands to run pre-commit hook manually, and then add a new commit for format fixing:

pip install pre-commit   # install pre-commit hook package
pre-commit install  # install pre-commit hook for current repo
pre-commit run --all-files  # run pre-commit checking for all file
git add xxx  # add changed files
git commit -m "xxx"  # create new commit
git push <repository> <refspec>  # push to remote

@MING-ZCH
Copy link
Contributor Author

已完成下载,但报错,本地也无法通过测试pre-commit run --all-files,求老师指导
Snipaste_2023-08-15_21-52-48
Snipaste_2023-08-15_23-15-40
Snipaste_2023-08-16_00-20-07

@LeoXing1996
Copy link
Collaborator

@MING-ZCH This seems a network error. You can set proxy for your command line.

@codecov
Copy link

codecov bot commented Aug 21, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (309ad75) 80.73% compared to head (a3f0dfd) 80.73%.

❗ Current head a3f0dfd differs from pull request most recent head 1be88f9. Consider uploading reports for the commit 1be88f9 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1982   +/-   ##
=======================================
  Coverage   80.73%   80.73%           
=======================================
  Files         424      424           
  Lines       29109    29109           
  Branches     4502     4502           
=======================================
  Hits        23502    23502           
  Misses       4630     4630           
  Partials      977      977           
Flag Coverage Δ
unittests 80.73% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

LeoXing1996
LeoXing1996 previously approved these changes Aug 21, 2023
@LeoXing1996 LeoXing1996 merged commit a06fb3b into open-mmlab:main Aug 21, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants