Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve] Fix niqe_pris_params.npz path when installed as package #995

Merged
merged 2 commits into from
Aug 5, 2022

Conversation

ychfan
Copy link

@ychfan ychfan commented Aug 3, 2022

No description provided.

wangruohui
wangruohui previously approved these changes Aug 5, 2022
@wangruohui
Copy link
Member

Hi,

Thanks for your contribution. Would you please format your code with yapf and isort to pass the linter?

Or you can use pre-commit hook, with

pip install pre-commit
pre-commit run --all-files

@wangruohui wangruohui changed the title Fix niqe_pris_params.npz path when installed as package [Improve] Fix niqe_pris_params.npz path when installed as package Aug 5, 2022
@codecov
Copy link

codecov bot commented Aug 5, 2022

Codecov Report

Merging #995 (114d0b4) into master (7888720) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #995      +/-   ##
==========================================
+ Coverage   83.54%   83.56%   +0.01%     
==========================================
  Files         223      223              
  Lines       12829    12830       +1     
  Branches     2096     2096              
==========================================
+ Hits        10718    10721       +3     
+ Misses       1783     1782       -1     
+ Partials      328      327       -1     
Flag Coverage Δ
unittests 83.52% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmedit/core/evaluation/metrics.py 97.08% <100.00%> (+0.01%) ⬆️
...ls/components/stylegan2/generator_discriminator.py 86.14% <0.00%> (+1.20%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants