Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version to 1.4 #2867

Merged
merged 7 commits into from
Jan 8, 2024
Merged

Bump version to 1.4 #2867

merged 7 commits into from
Jan 8, 2024

Conversation

ZwwWayne
Copy link
Collaborator

@ZwwWayne ZwwWayne commented Jan 8, 2024

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Bump version to 1.4

BC-breaking (Optional)

Does the modification introduce changes that break the back-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

Copy link

codecov bot commented Jan 8, 2024

Codecov Report

Attention: 167 lines in your changes are missing coverage. Please review.

Comparison is base (5c0613b) 46.70% compared to head (0ef13b8) 47.26%.

Files Patch % Lines
mmdet3d/evaluation/metrics/waymo_metric.py 9.52% 76 Missing ⚠️
...tion/functional/waymo_utils/prediction_to_waymo.py 0.00% 34 Missing ⚠️
mmdet3d/datasets/waymo_dataset.py 30.43% 27 Missing and 5 partials ⚠️
mmdet3d/models/detectors/multiview_dfm.py 29.03% 22 Missing ⚠️
mmdet3d/engine/hooks/visualization_hook.py 0.00% 0 Missing and 2 partials ⚠️
mmdet3d/models/detectors/dfm.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2867      +/-   ##
==========================================
+ Coverage   46.70%   47.26%   +0.55%     
==========================================
  Files         277      277              
  Lines       23635    23415     -220     
  Branches     3704     3655      -49     
==========================================
+ Hits        11039    11067      +28     
+ Misses      11892    11635     -257     
- Partials      704      713       +9     
Flag Coverage Δ
unittests 47.26% <19.71%> (+0.55%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ZwwWayne ZwwWayne merged commit fe25f7a into main Jan 8, 2024
35 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants