Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactor] refactor DOTA Dataset&Metric #446

Merged
merged 16 commits into from
Aug 11, 2022
Merged

[Refactor] refactor DOTA Dataset&Metric #446

merged 16 commits into from
Aug 11, 2022

Conversation

zytx121
Copy link
Collaborator

@zytx121 zytx121 commented Aug 3, 2022 •
edited
Loading

  • refactor DOTADataset
  • add UT
  • modify files which may cause UT to fail.
  • refactor FakeRotatedAnchorGenerator
  • refactor DOTAMetric

Reviewer: @RangiLyu

@zytx121 zytx121 added the dev-1.x label Aug 3, 2022
@zytx121 zytx121 requested a review from RangiLyu August 3, 2022 14:04
RangiLyu
RangiLyu reviewed Aug 4, 2022
View reviewed changes
Copy link
Member

@RangiLyu RangiLyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests/data/images/P2805__1024__0___0.png is 1.82MB which is too large, please use a smaller image.

RangiLyu
RangiLyu reviewed Aug 4, 2022
View reviewed changes
mmrotate/datasets/dota.py Outdated Show resolved Hide resolved
RangiLyu
RangiLyu reviewed Aug 4, 2022
View reviewed changes
mmrotate/datasets/dota.py Outdated Show resolved Hide resolved
RangiLyu
RangiLyu reviewed Aug 4, 2022
View reviewed changes
mmrotate/datasets/dota.py Outdated Show resolved Hide resolved
RangiLyu
RangiLyu reviewed Aug 4, 2022
View reviewed changes
mmrotate/datasets/dota.py Outdated Show resolved Hide resolved
RangiLyu
RangiLyu reviewed Aug 4, 2022
View reviewed changes
mmrotate/datasets/dota.py Outdated Show resolved Hide resolved
RangiLyu
RangiLyu reviewed Aug 5, 2022
View reviewed changes
mmrotate/datasets/dota.py Outdated Show resolved Hide resolved
@zytx121 zytx121 changed the title [Refactor] refactor DOTADataset [Refactor] refactor DOTADataset/Metric Aug 5, 2022
@zytx121 zytx121 changed the title [Refactor] refactor DOTADataset/Metric [Refactor] refactor DOTA Dataset/Metric Aug 5, 2022
@zytx121 zytx121 changed the title [Refactor] refactor DOTA Dataset/Metric [Refactor] refactor DOTA Dataset&Metric Aug 5, 2022
RangiLyu
RangiLyu reviewed Aug 9, 2022
View reviewed changes
mmrotate/datasets/dota.py Outdated Show resolved Hide resolved
zytx121 and others added 3 commits August 11, 2022 06:39
@zytx121 @RangiLyu
Update mmrotate/datasets/dota.py
f628509 
Co-authored-by: RangiLyu <lyuchqi@gmail.com>
@zytx121 @RangiLyu
Update mmrotate/evaluation/metrics/dota_metric.py
00fd002 
Co-authored-by: RangiLyu <lyuchqi@gmail.com>
@zytx121
Update dota_metric.py
c7906c3
@RangiLyu RangiLyu merged commit 0cb51bd into open-mmlab:dev-1.x Aug 11, 2022
triple-Mu pushed a commit to triple-Mu/mmrotate that referenced this pull request Jan 31, 2023
@zytx121 @RangiLyu @triple-Mu
[Refactor] refactor DOTA Dataset&Metric (open-mmlab#446)
2085866 
* update

* fix lint

* update ut

* fix

* Update dota.py

* Update dota.py

* Update anchor_generator.py

* Update dota.py

* Update registry.py

* update metric

* add format ut

* add merge_patches in DOTAMetric

* Update dota_metric.py

* Update mmrotate/datasets/dota.py

Co-authored-by: RangiLyu <lyuchqi@gmail.com>

* Update mmrotate/evaluation/metrics/dota_metric.py

Co-authored-by: RangiLyu <lyuchqi@gmail.com>

* Update dota_metric.py

Co-authored-by: RangiLyu <lyuchqi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RangiLyu RangiLyu RangiLyu approved these changes

Assignees
No one assigned
Labels
dev-1.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zytx121 @RangiLyu