Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix loss NaN bug when training HRSID dataset. #760

Merged
merged 2 commits into from
Mar 17, 2023

Conversation

zytx121
Copy link
Collaborator

@zytx121 zytx121 commented Mar 8, 2023

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

close #759

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the back-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. The documentation has been modified accordingly, like docstring or example tutorials.

@zytx121 zytx121 requested a review from liuyanyi March 8, 2023 01:29
@zytx121 zytx121 linked an issue Mar 8, 2023 that may be closed by this pull request
3 tasks
Copy link
Collaborator

@liuyanyi liuyanyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems 'FilterAnnotations' is under mmdet, should we add scope?

Co-authored-by: RangiLyu <lyuchqi@gmail.com>
@codecov
Copy link

codecov bot commented Mar 17, 2023

Codecov Report

❗ No coverage uploaded for pull request base (dev-1.x@53fc8b8). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             dev-1.x     #760   +/-   ##
==========================================
  Coverage           ?   79.35%           
==========================================
  Files              ?      100           
  Lines              ?     7267           
  Branches           ?     1039           
==========================================
  Hits               ?     5767           
  Misses             ?     1162           
  Partials           ?      338           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@RangiLyu RangiLyu merged commit c1aa0f9 into open-mmlab:dev-1.x Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Cannot run Oriented R-CNN and redet on HRSID, loss NAN
3 participants