Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Fix accepting an unexpected argument local-rank in PyTorch 2.0 #2812

Merged
merged 1 commit into from
Mar 30, 2023

Conversation

xiexinch
Copy link
Collaborator

Motivation

As title.

Ref: open-mmlab/mmagic#1712

@codecov
Copy link

codecov bot commented Mar 30, 2023

Codecov Report

Patch coverage: 80.00% and project coverage change: +0.05 🎉

Comparison is base (f6de1aa) 83.64% compared to head (3f0d5d3) 83.70%.

❗ Current head 3f0d5d3 differs from pull request most recent head 9f5f410. Consider uploading reports for the commit 9f5f410 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           dev-1.x    #2812      +/-   ##
===========================================
+ Coverage    83.64%   83.70%   +0.05%     
===========================================
  Files          156      156              
  Lines         9333     9355      +22     
  Branches      1367     1373       +6     
===========================================
+ Hits          7807     7831      +24     
+ Misses        1286     1279       -7     
- Partials       240      245       +5     
Flag Coverage Δ
unittests 83.70% <80.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmseg/datasets/transforms/formatting.py 97.72% <ø> (ø)
mmseg/evaluation/metrics/iou_metric.py 76.99% <77.27%> (-0.43%) ⬇️
mmseg/evaluation/metrics/citys_metric.py 87.01% <100.00%> (+0.34%) ⬆️

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@xiexinch xiexinch merged commit 23fb3a9 into open-mmlab:dev-1.x Mar 30, 2023
@xiexinch xiexinch deleted the fix-train-script branch March 30, 2023 08:43
nahidnazifi87 pushed a commit to nahidnazifi87/mmsegmentation_playground that referenced this pull request Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants