Render notes on metric semconv tables #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I ran the changed tool on the
|
Oberon00
approved these changes
May 31, 2023
lmolkova
approved these changes
May 31, 2023
jsuereth
approved these changes
Jun 1, 2023
arminru
approved these changes
Jun 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #167, part of open-telemetry/semantic-conventions#1086.
This only targets metrics, as for that we have a well-defined way to render in markdown (
to_markdown_metric_table). For other convention types such asresourcewe don't have a well-defined markdown "template" on how we want them to look so I left it for now.cc @trask