Fixed conditionally_required requirement_level. #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joaopgrassi
approved these changes
Sep 6, 2023
AlexanderWert
approved these changes
Sep 6, 2023
Oberon00
approved these changes
Sep 6, 2023
lmolkova
approved these changes
Sep 6, 2023
|
Hey. Thanks for all the approvals! What's the next step to get this merged? |
arminru
approved these changes
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
conditionally_requiredoption forrequirement_levelhas an error in the schema.json. This causes the vscode extension to flag an error when there is none. Here's an example from http-common:The fix is simply to change the properties to match
conditionally_required.