-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Track the deprecation of the SkyWalking exporter #23796
Comments
Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
@liqiangz I think you were keeping eyes on this. How about now? |
#6116 @jpkrohling Is there something required in it? |
The linked issue is about converting the benchmarks from the original PR into proper Go benchmarks. |
I just know these exporters are used by some SkyWalking users, although, SkyWalking has supported Otel native log and metrics formats too. |
@jpkrohling @wu-sheng Sorry, someone was assigned this issue before, I didn't pay attention to this issue anymore. I will finish this recently. |
Not only finishing that but handling user's questions related to the components: |
This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
I think I have answered most of it, and only one is pending as the #26315 is still in review. |
This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
@jpkrohling please follow up on this issue, as #30294 will impact the exporter. |
I believe the component is not in a better state than it was since this was first opened. In fact, it's a worse condition, given that the last code owner has been moved to emeritus due to inactivity. It's time to deprecate this component. |
Related to #23796, this marks the SkyWalking exporter as deprecated. Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de> --------- Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
Related to open-telemetry#23796, this marks the SkyWalking exporter as deprecated. Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de> --------- Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
Great news to SkyWalking users: you should now rely on SkyWalking's native OTLP ingestion port, as mentioned here: apache/skywalking#11909 Therefore, I think we should remove the SkyWalking exporter without fear that it would badly affect users. |
@jpkrohling the component status was updated to unmaintained on Jan 26, should the timeline in this issue be updated to reflect this? |
Done! |
Thanks @jpkrohling |
You probably don't even want to talk about this, but does it work? did it ever work? |
@jpkrohling it looks like we are past the June 14th date, and it’s time to remove the code. |
Fixes open-telemetry#23796 Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
Fixes #23796 --------- Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
Component(s)
exporter/skywalking
Describe the issue you're reporting
I'm listed as the code owner for the SkyWalkling exporter, as I volunteered for it when it was first proposed (#4956). A follow-up PR that was promised at that time (#6116) hasn't been done, and the code owner is not responsive even after being pinged directly.
I would like to start the deprecation process for this component.
https://github.com/open-telemetry/opentelemetry-collector#unmaintained
The text was updated successfully, but these errors were encountered: