Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track the deprecation of the SkyWalking exporter #23796

Closed
4 tasks done
jpkrohling opened this issue Jun 27, 2023 · 19 comments · Fixed by #33907
Closed
4 tasks done

Track the deprecation of the SkyWalking exporter #23796

jpkrohling opened this issue Jun 27, 2023 · 19 comments · Fixed by #33907
Assignees
Labels
comp:skywalking exporter/skywalking unmaintained Identifies issues/prs for unmaintained components

Comments

@jpkrohling
Copy link
Member

jpkrohling commented Jun 27, 2023

Component(s)

exporter/skywalking

Describe the issue you're reporting

I'm listed as the code owner for the SkyWalkling exporter, as I volunteered for it when it was first proposed (#4956). A follow-up PR that was promised at that time (#6116) hasn't been done, and the code owner is not responsive even after being pinged directly.

I would like to start the deprecation process for this component.

  • Wait 6 weeks for the code owner to provide feedback, either here or in the linked issue
  • Attempt to recruit new code owners, potentially from the SkyWalking community (cc @wu-sheng)
  • On Jan 26th, the component will be labeled as unmaintained if the original code owner is still unresponsive and no other code owner for the component has been found
  • On June 14th the component will be removed

https://github.com/open-telemetry/opentelemetry-collector#unmaintained

@github-actions
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@wu-sheng
Copy link

@liqiangz I think you were keeping eyes on this. How about now?

@wu-sheng
Copy link

#6116 @jpkrohling Is there something required in it?

@jpkrohling
Copy link
Member Author

The linked issue is about converting the benchmarks from the original PR into proper Go benchmarks.

@wu-sheng
Copy link

I just know these exporters are used by some SkyWalking users, although, SkyWalking has supported Otel native log and metrics formats too.
What do you expect to change? Finish that PR or something else?

@liqiangz
Copy link
Contributor

@jpkrohling @wu-sheng Sorry, someone was assigned this issue before, I didn't pay attention to this issue anymore. I will finish this recently.

@jpkrohling
Copy link
Member Author

jpkrohling commented Jul 10, 2023

What do you expect to change? Finish that PR or something else?

Not only finishing that but handling user's questions related to the components:

https://github.com/open-telemetry/opentelemetry-collector-contrib/issues?q=is%3Aopen+is%3Aissue+label%3Acomp%3Askywalking

@github-actions
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Sep 11, 2023
@jpkrohling
Copy link
Member Author

@wu-sheng, @liqiangz , was there any progress on the listed issues?

@wu-sheng
Copy link

I think I have answered most of it, and only one is pending as the #26315 is still in review.

@github-actions github-actions bot removed the Stale label Sep 12, 2023
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Nov 13, 2023
@atoulme
Copy link
Contributor

atoulme commented Jan 4, 2024

@jpkrohling please follow up on this issue, as #30294 will impact the exporter.

@github-actions github-actions bot removed the Stale label Jan 5, 2024
@jpkrohling
Copy link
Member Author

I believe the component is not in a better state than it was since this was first opened. In fact, it's a worse condition, given that the last code owner has been moved to emeritus due to inactivity. It's time to deprecate this component.

evan-bradley pushed a commit that referenced this issue Jan 26, 2024
Related to #23796, this marks the SkyWalking exporter as deprecated.

Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>

---------

Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
cparkins pushed a commit to AmadeusITGroup/opentelemetry-collector-contrib that referenced this issue Feb 1, 2024
Related to open-telemetry#23796, this marks the SkyWalking exporter as deprecated.

Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>

---------

Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
@jpkrohling
Copy link
Member Author

Great news to SkyWalking users: you should now rely on SkyWalking's native OTLP ingestion port, as mentioned here: apache/skywalking#11909

Therefore, I think we should remove the SkyWalking exporter without fear that it would badly affect users.

@codeboten
Copy link
Contributor

@jpkrohling the component status was updated to unmaintained on Jan 26, should the timeline in this issue be updated to reflect this?

@jpkrohling
Copy link
Member Author

Done!

@codeboten
Copy link
Contributor

Thanks @jpkrohling

@codeboten codeboten added the unmaintained Identifies issues/prs for unmaintained components label Apr 25, 2024
@kellis5137
Copy link

You probably don't even want to talk about this, but does it work? did it ever work?

@atoulme
Copy link
Contributor

atoulme commented Jul 3, 2024

@jpkrohling it looks like we are past the June 14th date, and it’s time to remove the code.

codeboten added a commit to codeboten/opentelemetry-collector-contrib that referenced this issue Jul 4, 2024
Fixes open-telemetry#23796

Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
codeboten added a commit that referenced this issue Jul 5, 2024
Fixes #23796

---------

Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:skywalking exporter/skywalking unmaintained Identifies issues/prs for unmaintained components
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants