Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[receiver/mongodb] database name reported as a datapoint attribute and as a resource attribute #24972

Closed
dmitryax opened this issue Aug 6, 2023 · 5 comments · Fixed by #33642
Closed

[receiver/mongodb] database name reported as a datapoint attribute and as a resource attribute #24972

dmitryax opened this issue Aug 6, 2023 · 5 comments · Fixed by #33642
Labels
bug Something isn't working help wanted Extra attention is needed never stale Issues marked with this label will be never staled and automatically removed receiver/mongodb

Comments

@dmitryax
Copy link
Member

dmitryax commented Aug 6, 2023 •
edited
Loading

Both resource and datapoint attributes are called database. One of them should be removed.
@dmitryax dmitryax added bug Something isn't working receiver/mongodb needs triage New item requiring triage labels Aug 6, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 6, 2023

Pinging code owners for receiver/mongodb: @djaglowski @schmikei. See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 6, 2023

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@djaglowski djaglowski self-assigned this Aug 7, 2023
@Frapschen Frapschen removed the needs triage New item requiring triage label Aug 9, 2023
@djaglowski djaglowski removed their assignment Sep 20, 2023
@djaglowski djaglowski added the help wanted Extra attention is needed label Sep 20, 2023
@sakulali sakulali mentioned this issue Oct 11, 2023
Merged
@github-actions GitHub Actions
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Nov 20, 2023
djaglowski pushed a commit that referenced this issue Nov 27, 2023
@sakulali
[receiver/mongodb] add receiver.mongodb.removeDatabaseAttr Alpha feat…
c27d056 
…ure gate (#27621)

**Description:** 
Add `receiver.mongodb.removeDatabaseAttr` Alpha feature gate to remove
duplicate database name attribute.

**Link to tracking Issue:** 

#24972

**Testing:** 
make generate
make chlog-validate
go test for mongodbreceiver

Manually tested, built image and manually enabled and disabled this
feature gate.

This is the warning we publish:

> 2023-10-15 17:06:29 2023-10-15T09:06:29.358Z warn
mongodbreceiver@v0.86.1-0.20231004185026-b5635a7a90d2/scraper.go:62
Feature gate receiver.mongodb.removeDatabaseAttr is not enabled. Please
see the README for more information:
https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/receiver/mongodbreceiver/README.md
{"kind": "receiver", "name": "mongodb", "data_type": "metrics"}


**Documentation:**

---------

Signed-off-by: sakulali <sakulali@126.com>
@github-actions GitHub Actions
Copy link
Contributor

This issue has been closed as inactive because it has been stale for 120 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jan 19, 2024
@djaglowski djaglowski removed the Stale label Jan 19, 2024
@djaglowski djaglowski reopened this Jan 19, 2024
@github-actions GitHub Actions
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Mar 21, 2024
@dmitryax dmitryax added never stale Issues marked with this label will be never staled and automatically removed and removed Stale labels Mar 21, 2024
@dmitryax dmitryax mentioned this issue Jun 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working help wanted Extra attention is needed never stale Issues marked with this label will be never staled and automatically removed receiver/mongodb
Projects
None yet
Milestone
No milestone
3 participants
@djaglowski @dmitryax @Frapschen