Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[exporter/elasticsearch] Set user-agent header #29898

Closed
strawgate opened this issue Dec 14, 2023 · 1 comment · Fixed by #29911
Closed

[exporter/elasticsearch] Set user-agent header #29898

strawgate opened this issue Dec 14, 2023 · 1 comment · Fixed by #29911
Assignees
@JaredTan95
Labels
enhancement New feature or request exporter/elasticsearch

Comments

@strawgate
Copy link
Contributor

strawgate commented Dec 14, 2023 •
edited
Loading

Component(s)

exporter/elasticsearch

Is your feature request related to a problem? Please describe.

The Elasticsearch exporter doesn't set the User-Agent header in the outgoing HTTP requests it makes, but it should.

Describe the solution you'd like

Following the pattern set in the otlphttpexporter, it should use fmt.Sprintf("%s/%s (%s/%s)", set.BuildInfo.Description, set.BuildInfo.Version, runtime.GOOS, runtime.GOARCH) as the user agent value.

Describe alternatives you've considered

No response

Additional context

No response
@strawgate strawgate added the needs triage New item requiring triage label Dec 14, 2023
@github-actions GitHub Actions
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@JaredTan95 JaredTan95 self-assigned this Dec 15, 2023
@JaredTan95 JaredTan95 removed the needs triage New item requiring triage label Dec 15, 2023
@JaredTan95 JaredTan95 mentioned this issue Dec 15, 2023
Merged
@crobert-1 crobert-1 added the enhancement New feature or request label Dec 15, 2023
@github-actions github-actions bot mentioned this issue Dec 19, 2023
Closed
bogdandrutu pushed a commit that referenced this issue Dec 21, 2023
@JaredTan95
[exporter/elasticsearch] set the default User-Agent header in the out…
e8ab66d 
…going HTTP requests (#29911)

**Description:** <Describe what has changed.>
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->

**Link to tracking Issue:** close
#29898

**Testing:** <Describe what testing was performed and which tests were
added.>

**Documentation:** <Describe the documentation added.>

---------

Signed-off-by: Jared Tan <jian.tan@daocloud.io>
cparkins pushed a commit to AmadeusITGroup/opentelemetry-collector-contrib that referenced this issue Jan 10, 2024
@JaredTan95 @cparkins
[exporter/elasticsearch] set the default User-Agent header in the out…
5b9aafd 
…going HTTP requests (open-telemetry#29911)

**Description:** <Describe what has changed.>
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->

**Link to tracking Issue:** close
open-telemetry#29898

**Testing:** <Describe what testing was performed and which tests were
added.>

**Documentation:** <Describe the documentation added.>

---------

Signed-off-by: Jared Tan <jian.tan@daocloud.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JaredTan95 JaredTan95

Labels
enhancement New feature or request exporter/elasticsearch
Projects
None yet
Milestone
No milestone
3 participants
@strawgate @JaredTan95 @crobert-1