Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[all] Use of component.UseLocalHostAsDefaultHost #30702

Closed
18 tasks done
mx-psi opened this issue Jan 22, 2024 · 3 comments · Fixed by #30987
Closed
18 tasks done

[all] Use of component.UseLocalHostAsDefaultHost #30702

mx-psi opened this issue Jan 22, 2024 · 3 comments · Fixed by #30987
Labels

Comments

@mx-psi
Copy link
Member

mx-psi commented Jan 22, 2024

Component(s)

No response

Describe the issue you're reporting

Once open-telemetry/opentelemetry-collector/pull/8622 gets merged and we add a similar package to contrib, we need to use the feature gate in the following components:

For each component we should:

  1. Change the default configuration to use the helper function
  2. Update documentation to say that this feature gate will change the default behavior
  3. Update any examples to use 0.0.0.0 if needed

See #30820 for an example

This is on hold for now, will remove the label and add more detailed instructions when we can move forward with this

@atoulme
Copy link
Contributor

atoulme commented Jan 25, 2024

For processor/remotetapprocessor, given that it's alpha, I will elect to make a direct breaking change. I will post the PR here for review and make sure folks can 👍 / 👎 as needed

mx-psi added a commit that referenced this issue Jan 29, 2024
**Description:** 

Follow up to open-telemetry/opentelemetry-collector/pull/8622

**Link to tracking Issue:** First step of #30702
@mx-psi mx-psi removed the on hold This is blocked by another PR/issue label Jan 29, 2024
@mx-psi
Copy link
Member Author

mx-psi commented Jan 29, 2024

No longer on hold. I marked JMX receiver as done since the endpoint is for an internal OTLP exporter, not for a receiver.

@atoulme
Copy link
Contributor

atoulme commented Jan 31, 2024

Change of plans for remotetapprocessor, it will use the feature gate after all: #30905

mx-psi pushed a commit that referenced this issue Jan 31, 2024
…stAsDefaultHost` feature gate (#30905)

**Description:**
remotetapprocessor adopts `component.UseLocalHostAsDefaultHost` feature
gate

**Link to tracking Issue:** <Issue number if applicable>

#30702

**Documentation:**
Updated docs.
mx-psi added a commit that referenced this issue Jan 31, 2024
…sDefaultHost` feature gate` (#30847)

**Description:**
Add `component.UseLocalHostAsDefaultHost` feature gate that changes
default endpoints from 0.0.0.0 to localhost

**Link to tracking Issue:**
#30702

**Documentation:**
Updated docs.

Co-authored-by: Pablo Baeyens <pbaeyens31+github@gmail.com>
mx-psi pushed a commit that referenced this issue Jan 31, 2024
…DefaultHost` feature gate (#30906)

**Description:**
signalfxreceiver adopts `component.UseLocalHostAsDefaultHost` feature
gate

**Link to tracking Issue:**
#30702 

**Documentation:**
Updated docs.
mx-psi pushed a commit that referenced this issue Feb 1, 2024
… feature gate (#30978)

Description:
skywalkingreceiver adopts component.UseLocalHostAsDefaultHost feature
gate

Link to tracking Issue:

#30702

Fixes #30977 

Documentation:
Updated docs.
mx-psi added a commit that referenced this issue Feb 1, 2024
…ultHost` feature gate (#30980)

Description:
jaegerreceiver adopts component.UseLocalHostAsDefaultHost feature gate

Link to tracking Issue:

#30702

Fixes
#30979

Documentation:
Updated docs.

Co-authored-by: Pablo Baeyens <pbaeyens31+github@gmail.com>
mx-psi added a commit that referenced this issue Feb 1, 2024
…nt.UseLocalHostAsDefaultHost` feature gate (#30983)

Description:
jaegerremotesampling extension adopts
component.UseLocalHostAsDefaultHost feature gate

Link to tracking Issue:

#30702

Fixes
#30982

Documentation:
Updated docs.

Co-authored-by: Pablo Baeyens <pbaeyens31+github@gmail.com>
mx-psi added a commit that referenced this issue Feb 1, 2024
…ost` feature gate (#30926)

**Description:**
sapmreceiver adopts `component.UseLocalHostAsDefaultHost` feature gate

**Link to tracking Issue:**
#30702 

**Documentation:**
Updated docs.

---------

Co-authored-by: Pablo Baeyens <pbaeyens31+github@gmail.com>
mx-psi added a commit that referenced this issue Feb 1, 2024
…tAsDefaultHost` feature gate (#30985)

Description:
awsproxy extension adopts `component.UseLocalHostAsDefaultHost` feature
gate

Link to tracking Issue:

#30702

Fixes
#30984

Documentation:
Updated docs.

Co-authored-by: Pablo Baeyens <pbaeyens31+github@gmail.com>
mx-psi added a commit that referenced this issue Feb 1, 2024
…ure gate (#30987)

Description:
internal/aws/proxy adopts `component.UseLocalHostAsDefaultHost` feature
gate

Link to tracking Issue:

#30702

Fixes
#30986

Documentation:
Updated docs.

---------

Co-authored-by: Pablo Baeyens <pbaeyens31+github@gmail.com>
Co-authored-by: Pablo Baeyens <pablo.baeyens@datadoghq.com>
cparkins pushed a commit to AmadeusITGroup/opentelemetry-collector-contrib that referenced this issue Feb 1, 2024
cparkins pushed a commit to AmadeusITGroup/opentelemetry-collector-contrib that referenced this issue Feb 1, 2024
…stAsDefaultHost` feature gate (open-telemetry#30905)

**Description:**
remotetapprocessor adopts `component.UseLocalHostAsDefaultHost` feature
gate

**Link to tracking Issue:** <Issue number if applicable>

open-telemetry#30702

**Documentation:**
Updated docs.
cparkins pushed a commit to AmadeusITGroup/opentelemetry-collector-contrib that referenced this issue Feb 1, 2024
…sDefaultHost` feature gate` (open-telemetry#30847)

**Description:**
Add `component.UseLocalHostAsDefaultHost` feature gate that changes
default endpoints from 0.0.0.0 to localhost

**Link to tracking Issue:**
open-telemetry#30702

**Documentation:**
Updated docs.

Co-authored-by: Pablo Baeyens <pbaeyens31+github@gmail.com>
cparkins pushed a commit to AmadeusITGroup/opentelemetry-collector-contrib that referenced this issue Feb 1, 2024
…DefaultHost` feature gate (open-telemetry#30906)

**Description:**
signalfxreceiver adopts `component.UseLocalHostAsDefaultHost` feature
gate

**Link to tracking Issue:**
open-telemetry#30702 

**Documentation:**
Updated docs.
cparkins pushed a commit to AmadeusITGroup/opentelemetry-collector-contrib that referenced this issue Feb 1, 2024
… feature gate (open-telemetry#30978)

Description:
skywalkingreceiver adopts component.UseLocalHostAsDefaultHost feature
gate

Link to tracking Issue:

open-telemetry#30702

Fixes open-telemetry#30977 

Documentation:
Updated docs.
cparkins pushed a commit to AmadeusITGroup/opentelemetry-collector-contrib that referenced this issue Feb 1, 2024
…ultHost` feature gate (open-telemetry#30980)

Description:
jaegerreceiver adopts component.UseLocalHostAsDefaultHost feature gate

Link to tracking Issue:

open-telemetry#30702

Fixes
open-telemetry#30979

Documentation:
Updated docs.

Co-authored-by: Pablo Baeyens <pbaeyens31+github@gmail.com>
cparkins pushed a commit to AmadeusITGroup/opentelemetry-collector-contrib that referenced this issue Feb 1, 2024
…nt.UseLocalHostAsDefaultHost` feature gate (open-telemetry#30983)

Description:
jaegerremotesampling extension adopts
component.UseLocalHostAsDefaultHost feature gate

Link to tracking Issue:

open-telemetry#30702

Fixes
open-telemetry#30982

Documentation:
Updated docs.

Co-authored-by: Pablo Baeyens <pbaeyens31+github@gmail.com>
cparkins pushed a commit to AmadeusITGroup/opentelemetry-collector-contrib that referenced this issue Feb 1, 2024
…ost` feature gate (open-telemetry#30926)

**Description:**
sapmreceiver adopts `component.UseLocalHostAsDefaultHost` feature gate

**Link to tracking Issue:**
open-telemetry#30702 

**Documentation:**
Updated docs.

---------

Co-authored-by: Pablo Baeyens <pbaeyens31+github@gmail.com>
cparkins pushed a commit to AmadeusITGroup/opentelemetry-collector-contrib that referenced this issue Feb 1, 2024
…tAsDefaultHost` feature gate (open-telemetry#30985)

Description:
awsproxy extension adopts `component.UseLocalHostAsDefaultHost` feature
gate

Link to tracking Issue:

open-telemetry#30702

Fixes
open-telemetry#30984

Documentation:
Updated docs.

Co-authored-by: Pablo Baeyens <pbaeyens31+github@gmail.com>
cparkins pushed a commit to AmadeusITGroup/opentelemetry-collector-contrib that referenced this issue Feb 1, 2024
…ure gate (open-telemetry#30987)

Description:
internal/aws/proxy adopts `component.UseLocalHostAsDefaultHost` feature
gate

Link to tracking Issue:

open-telemetry#30702

Fixes
open-telemetry#30986

Documentation:
Updated docs.

---------

Co-authored-by: Pablo Baeyens <pbaeyens31+github@gmail.com>
Co-authored-by: Pablo Baeyens <pablo.baeyens@datadoghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants